From 81865cb7ac08b55498a2b63158c82f81d413eec0 Mon Sep 17 00:00:00 2001 From: fox3000foxy <40730498+fox3000foxy@users.noreply.github.com> Date: Fri, 12 Sep 2025 18:04:36 +0200 Subject: [PATCH] add string bounds check when copying player name --- src/packets.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/packets.c b/src/packets.c index 245c100..b3cbb3d 100644 --- a/src/packets.c +++ b/src/packets.c @@ -63,7 +63,8 @@ int cs_loginStart (int client_fd, uint8_t *uuid, char *name) { readString(client_fd); if (recv_count == -1) return 1; - memcpy(name, recv_buffer, strlen((char *)recv_buffer) + 1); + strncpy(name, (char *)recv_buffer, 16 - 1); + name[16 - 1] = '\0'; printf(" Player name: %s\n", name); recv_count = recv_all(client_fd, recv_buffer, 16, false); if (recv_count == -1) return 1;