alexander.nutz/barecopper
1
0
Fork 0
forked from EXTERNAL/bareiron
Code Pull Requests Activity

Close file on error paths to prevent resource leak

Browse Source
This commit is contained in:
vil02
2025-09-14 19:29:19 +02:00
committed by p2r3
parent 6a65b8acba
commit 200106bb46
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/serialize.c
View File

@@ -45,6 +45,7 @@ int initSerializer () {
size_t read = fread(block_changes, 1, sizeof(block_changes), file); size_t read = fread(block_changes, 1, sizeof(block_changes), file);
if (read != sizeof(block_changes)) { if (read != sizeof(block_changes)) {
printf("Read %u bytes from \"world.bin\", expected %u (block changes). Aborting.\n", read, sizeof(block_changes)); printf("Read %u bytes from \"world.bin\", expected %u (block changes). Aborting.\n", read, sizeof(block_changes));
fclose(file);
return 1; return 1;
} }
// Find the index of the last occupied entry to recover block_changes_count // Find the index of the last occupied entry to recover block_changes_count
@@ -56,6 +57,7 @@ int initSerializer () {
// Seek past block changes to start reading player data // Seek past block changes to start reading player data
if (fseek(file, sizeof(block_changes), SEEK_SET) != 0) { if (fseek(file, sizeof(block_changes), SEEK_SET) != 0) {
perror("Failed to seek to player data in \"world.bin\". Aborting."); perror("Failed to seek to player data in \"world.bin\". Aborting.");
fclose(file);
return 1; return 1;
} }
// Read player data directly into memory // Read player data directly into memory
@@ -86,6 +88,7 @@ int initSerializer () {
"Failed to write initial block data to \"world.bin\".\n" "Failed to write initial block data to \"world.bin\".\n"
"Consider checking permissions or disabling SYNC_WORLD_TO_DISK in \"globals.h\"." "Consider checking permissions or disabling SYNC_WORLD_TO_DISK in \"globals.h\"."
); );
fclose(file);
return 1; return 1;
} }
// Seek past written block changes to start writing player data // Seek past written block changes to start writing player data
@@ -94,6 +97,7 @@ int initSerializer () {
"Failed to seek past block changes in \"world.bin\"." "Failed to seek past block changes in \"world.bin\"."
"Consider checking permissions or disabling SYNC_WORLD_TO_DISK in \"globals.h\"." "Consider checking permissions or disabling SYNC_WORLD_TO_DISK in \"globals.h\"."
); );
fclose(file);
return 1; return 1;
} }
// Write initial player data to disk (should be just nulls?) // Write initial player data to disk (should be just nulls?)